NO-ISSUE: [OTE] Refac: refac helper and olmv1 test to create namespace instead to use pre-existent #426
Conversation
|
@camilamacedo86: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
| @@ -2,25 +2,27 @@ package helpers | |||
|
|
|||
| import ( | |||
| "context" | |||
| "fmt" | |||
| "time" | |||
There was a problem hiding this comment.
This is an improvement:
- I just want to ensure that the tests run in a new namespace — meaning they’re fully isolated.
- I also refactored the helper so it’s easier to reuse in other tests. In many cases, we need to create the ClusterExtension and check that is installed. The code is centralised to facilitate. If you check the other open PRs that use this helper, I’ve already made sure they match the same version we have here.
Could you help me get this one merged? 🙏
… namespace instead to use pre-existent
|
/test openshift-e2e-aws |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@camilamacedo86: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 56f527a
into
openshift:main
|
[ART PR BUILD NOTIFIER] Distgit: ose-olm-operator-controller |
|
[ART PR BUILD NOTIFIER] Distgit: ose-olm-catalogd |
The refactoring will be required for the other tests to use the helper
Also, it ensures that we create a namespace specific to the test instead of using a pre-existing one to ensure that tests are isolated.
Also, we are making the test more robust to avoid flakes by ensuring that the CE and CRD do not exist on the cluster before trying to install.